Bugfix: Temperature checks when no heaters in use #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit checks whether or not HEATER_0 is in use, and if not, skips the MIN / MAX temperature checks.
| if (current_temperature_raw[0] GE0 maxttemp_raw[0]) max_temp_error(0); | ||
| if (minttemp_raw[0] GE0 current_temperature_raw[0]) min_temp_error(0); | ||
| #endif | ||
| #endif |
There was a problem hiding this comment.
Good addition! Just have to replace tabs with spaces here - 2 space indent.
thinkyhead
added a commit
that referenced
this pull request
Apr 7, 2015
Bugfix: Temperature checks when no heaters in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a system with no heaters (such as CNC mill) the MIN / MAX temperature checks were causing errors to be reported, preventing the machine from working. This conditional statement prevents that, without affecting the check in firmware for running printers