remove need for HEATER_0_PIN if EXTRUDERS is 0 #18827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domrim
pushed a commit
to domrim/Marlin
that referenced
this pull request
Aug 2, 2020
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Aug 13, 2020
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
ahmetcemturan
pushed a commit
to ahmetcemturan/Marlin
that referenced
this pull request
Jan 21, 2021
ahmetcemturan
added a commit
to ahmetcemturan/Marlin
that referenced
this pull request
Jan 23, 2021
This reverts commit 5f5fc92.
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
If you are using Marlin for a non 3d printer SanityCheck.h requires a valid HEATER_0_PIN
Description
I have modified the test so that if EXTRUDERS < 1 (ie no hot ends) you don't need a HEATER_0_PIN defined.
Benefits
More CNC/Non 3d printer friendly
Related Issues
Was raised on reprap forum https://reprap.org/forum/read.php?415,875542,875572
A user wanted to use D8,D9,D10 on his ramps for CNC things..