Fix PIO warning about new marlin config
#18935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gives any warning
|
Aha, I figured there must me some facility in PlatformIO to allow for custom but ignored values. This will work. I was thinking maybe |
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Aug 13, 2020
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
ahmetcemturan
pushed a commit
to ahmetcemturan/Marlin
that referenced
this pull request
Jan 21, 2021
ahmetcemturan
added a commit
to ahmetcemturan/Marlin
that referenced
this pull request
Jan 23, 2021
)" This reverts commit 7061f39.
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PIO warns about the new
marlin.env config. To get rid of PIO warnings, we need to prefix the new config withcustom_.I really do like
marlin.. But withcustom_marlin.we get no warning.Verified in the PIO source code:
~/.platformio/penv/python-xx/site-packages/platformio/project/config.py:170Benefits
Fixes #18934
Related Issues
#18934
#18919