Add CR10_STOCKDISPLAY checks to pins_CREALITY_V4.h #19019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
den-kozlov
pushed a commit
to den-kozlov/Marlin_for_Hypercube
that referenced
this pull request
Aug 18, 2020
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Aug 20, 2020
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
CREALITY_V4 controller with a CR10_STOCKDISPLAY display
Description
Creality seems to have started shipping CREALITY_V4 for everyone. (as ender 3 silent board upgrades for eg)
Those selecting CR10_STOCKDISPLAY get compile errors as they need an additional #define they are not aware of.
either #define RET6_12864_LCD or #define VET6_12864_LCD is needed. Depending on MPU version board comes with
Benefits
Marlin now warns users they need to set one of these defines if they enable CR10_STOCKDISPLAY on this controller.
Related Issues
Seen this asked on discord and now issue #19015