Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Configuration for K8200: comments/URL/readme #1917

Conversation

CONSULitAS
Copy link
Contributor

example_configurations\K8200\Configuration.h:

  • add machine specific header
  • change STRING_URL to K8200 fork (@thinkyhead: What do you think?)

example_configurations\K8200\readme.md:

  • updated documentation
  • added URLs and links

Example Configuration for K8200 : comments/URL/readme

example_configurations\K8200\Configuration.h:
* add machine specific header
* change STRING_URL to K8200 fork (@thinkyhead: What do you think?)

example_configurations\K8200\readme.md:
* updated documentation
* added URLs and links
Example Configuration for K8200 : comments/URL/readme

example_configurations\K8200\Configuration.h:
* add machine specific header
* change STRING_URL to K8200 fork (@thinkyhead: What do you think?)

example_configurations\K8200\readme.md:
* updated documentation
* added URLs and links
@CONSULitAS CONSULitAS changed the title Example Configuration for K8200 : comments/URL/readme Example Configuration for K8200: comments/URL/readme Apr 15, 2015
@CONSULitAS
Copy link
Contributor Author

@thinkyhead should we add headers to all sample configs like that?

@thinkyhead
Copy link
Member

@CONSULitAS Yes, I favor documentation headings like that on the config files, including the author names, if applicable - the Github nicks of their caretakers.

Well, interestingly, STRING_URL is not used anywhere, so I think we can remove it. The right place for that setting is FIRMWARE_URL. That should always be a link to a Github fork of Marlin, if there is one, or the download page for the vendor, if they have one. If neither of those exist, then it should just revert to the default – this repo.

…4-23_TEST

Conflicts:
	Marlin/example_configurations/K8200/Configuration.h
K8200 example Configuration.h:
* STRING_URL removed: like proposed by thinkyhead in MarlinFirmware#1917
@CONSULitAS
Copy link
Contributor Author

@thinkyhead update should correct merge conflicts and STRING_URL removed, FIRMWARE_URL to come with other PR later

@CONSULitAS
Copy link
Contributor Author

@thinkyhead @boelle Why is "Hardware Support" now "On Hold During Bugfix"?

  • How should we test without hardware support?
  • If there are only example files are changed, no productive code will be broken.
  • Instead of this I try to keep the config in sync, so the bugfix release can be tested by as much people as possible.
  • The longer this is pending we will have more merge conflicts. Annoying to get rid of them.

Thanks in advance

a caretaker :-)

@thinkyhead
Copy link
Member

"On Hold" is kind of informal and discretionary. Language support, hardware support, and innocuous changes that are concise are not being completely held up. But significant new features are.

thinkyhead added a commit that referenced this pull request Apr 28, 2015
Example Configuration for K8200: comments/URL/readme
@thinkyhead thinkyhead merged commit 185f8a0 into MarlinFirmware:Development Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants