-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only set touchscreen offsets if they aren't defined #19196
Conversation
Only set touchscreen offsets if they aren't defined in the configuration.h to get rid of the nasty double definition massages
The default values didn't work for you? |
After all this TFT refactoring, you shouldn't need to manually define those values anymore. |
In fact. Even more true for Nano v1.2. Nano v1.2 board have a FSMC interface. It means that it will be rarely changed. FSMC is connected directly to the mcu, pin by pin. It may work only with the mks tft. I thought that no user will ever change it. @G4Cab The default values aren't working for you? |
Anyway, this PR could be merged, as it only add the option for the user override the default Xpt values |
Had from an older marlin this in my config and runned into massive warnings, after i understand everything i tried the default values without any luck of having the correct calibration. After some try and error i got it working after reload factory defaults with M502 over pronterface. thaught that this was forgotten and added the changes. |
Only set touchscreen offsets if they aren't defined in the configuration.h to get rid of the nasty double definition massages