Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set touchscreen offsets if they aren't defined #19196

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Only set touchscreen offsets if they aren't defined #19196

merged 2 commits into from
Aug 31, 2020

Conversation

G4Cab
Copy link
Contributor

@G4Cab G4Cab commented Aug 30, 2020

Only set touchscreen offsets if they aren't defined in the configuration.h to get rid of the nasty double definition massages

Only set touchscreen offsets if they aren't defined in the configuration.h to get rid of the nasty double definition massages
@rhapsodyv
Copy link
Member

The default values didn't work for you?
🤔

@thisiskeithb
Copy link
Member

After all this TFT refactoring, you shouldn't need to manually define those values anymore.

@rhapsodyv
Copy link
Member

After all this TFT refactoring, you shouldn't need to manually define those values anymore.

In fact. Even more true for Nano v1.2. Nano v1.2 board have a FSMC interface. It means that it will be rarely changed. FSMC is connected directly to the mcu, pin by pin. It may work only with the mks tft. I thought that no user will ever change it.
So, if the defaults xpt works for one user, it must work for all ... That is the reason I kept those config without the #ifdef...

@G4Cab The default values ​​aren't working for you?

@rhapsodyv
Copy link
Member

Anyway, this PR could be merged, as it only add the option for the user override the default Xpt values

@G4Cab
Copy link
Contributor Author

G4Cab commented Aug 31, 2020

After all this TFT refactoring, you shouldn't need to manually define those values anymore.

In fact. Even more true for Nano v1.2. Nano v1.2 board have a FSMC interface. It means that it will be rarely changed. FSMC is connected directly to the mcu, pin by pin. It may work only with the mks tft. I thought that no user will ever change it.
So, if the defaults xpt works for one user, it must work for all ... That is the reason I kept those config without the #ifdef...

@G4Cab The default values ​​aren't working for you?

Had from an older marlin this in my config and runned into massive warnings, after i understand everything i tried the default values without any luck of having the correct calibration.

After some try and error i got it working after reload factory defaults with M502 over pronterface.

thaught that this was forgotten and added the changes.

@thinkyhead thinkyhead merged commit 4ab4dbb into MarlinFirmware:bugfix-2.0.x Aug 31, 2020
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Sep 2, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants