Fix Color UI external_control, wait_for_release #19771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
changed the title
Zorchz
pushed a commit
to Zorchz/Marlin-1
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Zorchz
pushed a commit
to Zorchz/Marlin-1
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Oct 21, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Oct 23, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Nov 2, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 8, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 11, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 30, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MarlinUI::wait_for_release()didn't set thewait_for_userflag. It's needed for the color ui, to allow click anywhere in the screen.Clean the internal click state of the color ui, after it is consumed, so it only gives one click command. It may solve the
MarlinUI::wait_for_release()bug.And it fixes the
wait_for_userwhileexternal_controlis set, for color ui.This PR fix that.
Benefits
Fix UBL for Color UI.
Fix #19758
Related Issues
#19758