Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct Chopper Timing settings #19781

Conversation

jagoosw
Copy link
Contributor

@jagoosw jagoosw commented Oct 17, 2020

Description

Issue #18667 requests for the chopper timing for stealth chop to be able to be set independently to allow it to work properly when axis have different steppers.

Benefits

This adds this functionality allowing each one to be set in the same way as the default one is set.

Configurations

Similar to setting stepper drivers this is configured by defining a timing for each axis, or if no timing is set the default is used.

Uncomment and change the configurations for each axis below in Configuration_adv.h to enable for each axis, setting their values as with the old default one.

  #define CHOPPER_TIMING CHOPPER_DEFAULT_12V
  //For different timings for each axis set below, otherwise default timings will be used
  //#define CHOPPER_TIMING_Y CHOPPER_DEFAULT_12V
  //#define CHOPPER_TIMING_Z CHOPPER_DEFAULT_12V
  //#define CHOPPER_TIMING_E CHOPPER_DEFAULT_12V   

Related Issues

Issue #18667

Add separate chopper timing as requested in Issue [MarlinFirmware#18667](MarlinFirmware#18667).

Configured by adding particular axis chopper timings in Configuration_adv.h
@jagoosw
Copy link
Contributor Author

jagoosw commented Oct 17, 2020

Apologies for messing up the requests originally.

@jagoosw
Copy link
Contributor Author

jagoosw commented Oct 17, 2020

I'm confused by the test failures because the config files were fresh from the bugfix branch before I modified them

@thisiskeithb
Copy link
Member

I'm confused by the test failures because the config files were fresh from the bugfix branch before I modified them

If you look at the Files changed tab, you'll need to revert several lines in Configuration_adv.h since they are old/overwriting recent changes.

@thinkyhead
Copy link
Member

Getting closer. Notice that currently only .toff will differ between X and X2, Y and Y2, etc., because it's the only parameter pulled from the extra chopper configs. To also get the .hend and .hstart parameters for the extra axes, the tmc_init methods will need to be altered to accept a chopper_timing_t structure reference as input.

@thinkyhead thinkyhead force-pushed the bugfix-2.0.x-separate-chopper-timing branch from e98ece2 to 51966cb Compare October 18, 2020 03:30
@thinkyhead thinkyhead merged commit c2802d3 into MarlinFirmware:bugfix-2.0.x Oct 18, 2020
@thinkyhead thinkyhead changed the title Add separate chopper timing Distinct Chopper Timing settings Oct 18, 2020
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Oct 21, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Oct 23, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Nov 2, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
thinkyhead added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants