-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dagoma F5 board configuration #19947
Update Dagoma F5 board configuration #19947
Conversation
You'll want to add a sanity check to alert users that the board name has changed. |
Hi @thisiskeithb , Thanks for the advice , i will do this asap. Regards, |
I have some general concerns about this and the changes in the corresponding example PR. The changes are so extreme that it makes me question whether they are even the same printer. I think @InsanityAutomation wrote the original example, so I presume this is one of the printers he has worked with. |
Hi @sjasonsmith , The original version was a kind of draft with many missing stuff. I've discussed with @InsanityAutomation on this topic several weeks/months ago. I am not sure he owns this printer. I let him confirm. I own this printer but I didn't have any time to finalize the work until this week. I am curious about the extreme changes you point out. If you speak about DAC steppers for instance, i confirm, the board has a mcp4728 chip. Regards, |
By "extreme change" I was referring more to replacing the board, and the changes in the examples. Switching the example to two extruders stands out as a major change for an example. Users often submit changes that help them while hurting everybody else, and I wanted to be sure that was not the case here. InsanityAutomation has informed me that you are actually the expert on these printers, so I can step back and let you do your work. |
@sjasonsmith : I confirm having the dual extruders configuration file with e1 stepper and filrunout unplugged (so physical config equivalent to single extruder) works flawlessly. @thinkyhead : Thanks for the improvements, especially the sanity check addition (i planned to do this today, but you are too fast!). |
Hi,
This PR updates the Dagoma F5 board pins configuration.
It comes with an update of the related printer configuration in a PR submitted on the Configurations repository.
Regards,
Orel