Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dagoma F5 board configuration #19947

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

0r31
Copy link
Contributor

@0r31 0r31 commented Oct 29, 2020

Hi,

This PR updates the Dagoma F5 board pins configuration.
It comes with an update of the related printer configuration in a PR submitted on the Configurations repository.

Regards,
Orel

@thisiskeithb
Copy link
Member

You'll want to add a sanity check to alert users that the board name has changed.

@0r31
Copy link
Contributor Author

0r31 commented Oct 29, 2020

Hi @thisiskeithb ,

Thanks for the advice , i will do this asap.

Regards,
Orel

@sjasonsmith
Copy link
Contributor

I have some general concerns about this and the changes in the corresponding example PR.

The changes are so extreme that it makes me question whether they are even the same printer. I think @InsanityAutomation wrote the original example, so I presume this is one of the printers he has worked with.

@0r31
Copy link
Contributor Author

0r31 commented Oct 29, 2020

Hi @sjasonsmith ,

The original version was a kind of draft with many missing stuff.

I've discussed with @InsanityAutomation on this topic several weeks/months ago. I am not sure he owns this printer. I let him confirm.

I own this printer but I didn't have any time to finalize the work until this week.

I am curious about the extreme changes you point out.

If you speak about DAC steppers for instance, i confirm, the board has a mcp4728 chip.
Another major change is related to the fact that i introduce the second optional extruder (which doesn't have any impact on single extruder configuration).
That's all i see as extreme. All other stuff are small details (adding language choice,...)

Regards,
Orel

@sjasonsmith
Copy link
Contributor

By "extreme change" I was referring more to replacing the board, and the changes in the examples. Switching the example to two extruders stands out as a major change for an example.

Users often submit changes that help them while hurting everybody else, and I wanted to be sure that was not the case here.

InsanityAutomation has informed me that you are actually the expert on these printers, so I can step back and let you do your work.

@0r31
Copy link
Contributor Author

0r31 commented Oct 29, 2020

@sjasonsmith ,

I understand your initial concerns. You were right to warn on these changes. Here is few more explanations.

I changed the board filename as it reflects the board name itself:
image

I set the extruders number to 2 and expect no different behavior as it is a single nozzle printer.
On this point, let me double check that tomorrow morning in unplugging second extruder motor and filament runout.

Regards,
Orel

@thinkyhead thinkyhead merged commit a272c01 into MarlinFirmware:bugfix-2.0.x Oct 30, 2020
@0r31
Copy link
Contributor Author

0r31 commented Oct 30, 2020

@sjasonsmith : I confirm having the dual extruders configuration file with e1 stepper and filrunout unplugged (so physical config equivalent to single extruder) works flawlessly.

@thinkyhead : Thanks for the improvements, especially the sanity check addition (i planned to do this today, but you are too fast!).

vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants