Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy value from IDEX menus and add post command option to M605 #20133

Merged

Conversation

InsanityAutomation
Copy link
Contributor

First half of changes related to #17941

@Roxy-3D
Copy link
Member

Roxy-3D commented Nov 13, 2020

Is this going to work? The M605 S3 X200 was needed to get the extruders spaced properly....

@InsanityAutomation
Copy link
Contributor Author

Just verified in the issues thread that it is applying the default correctly. The value persisted from the default assignment in motion.cpp from configuration_adv with no X arg ever assigned.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 2 times, most recently from 4274255 to a97a1ae Compare November 14, 2020 02:06
@DrumClock
Copy link

Hi @thinkyhead
I can't compile it.

Compiling .pio\build\BIGTREE_GTR_V1_0\src\src\lcd\menu\menu_mixer.cpp.o
In file included from Marlin\src\lcd\menu\menu_configuration.cpp:31:
Marlin\src\lcd\menu\menu_configuration.cpp: In function 'void menu_idex()':
Marlin\src\lcd\menu\menu_item.h:259:40: error: no matching function for call to 'TMenuEditItem<MenuEditItemInfo_float42_52>::action(const char* const&, float*)'      
  259 |     MenuItem_##TYPE::action(plabel, ##V);                      \
      |                                        ^
Marlin\src\lcd\menu\menu_item.h:270:5: note: in expansion of macro '_MENU_INNER_P'
  270 |     _MENU_INNER_P(TYPE, ##V);         \
      |     ^~~~~~~~~~~~~
Marlin\src\lcd\menu\menu_item.h:354:57: note: in expansion of macro '_MENU_ITEM_P'
  354 | #define MENU_ITEM_P(TYPE, PLABEL, V...)                 _MENU_ITEM_P(TYPE, false, PLABEL, ##V)
      |                                                         ^~~~~~~~~~~~
Marlin\src\lcd\menu\menu_item.h:392:58: note: in expansion of macro 'MENU_ITEM_P'
  392 | #define EDIT_ITEM_P(TYPE, PLABEL, V...)                  MENU_ITEM_P(TYPE, PLABEL, ##V)
      |                                                          ^~~~~~~~~~~
Marlin\src\lcd\menu\menu_item.h:393:58: note: in expansion of macro 'EDIT_ITEM_P'
  393 | #define EDIT_ITEM(TYPE, LABEL, V...)                     EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
      |                                                          ^~~~~~~~~~~
Marlin\src\lcd\menu\menu_configuration.cpp:207:5: note: in expansion of macro 'EDIT_ITEM'
  207 |     EDIT_ITEM(float42_52, MSG_IDEX_DUPE_GAP, &duplicate_extruder_x_offset);
      |     ^~~~~~~~~
Marlin\src\lcd\menu\menu_item.h:93:17: note: candidate: 'static void TMenuEditItem<NAME>::action(const char*, TMenuEditItem<NAME>::type_t*, TMenuEditItem<NAME>::type_t, TMenuEditItem<NAME>::type_t, screenFunc_t, bool) [with NAME = MenuEditItemInfo_float42_52; TMenuEditItem<NAME>::type_t = float; screenFunc_t = void (*)()]'        
   93 |     static void action(
      |                 ^~~~~~
Marlin\src\lcd\menu\menu_item.h:93:17: note:   candidate expects 6 arguments, 2 provided
*** [.pio\build\BIGTREE_GTR_V1_0\src\src\lcd\menu\menu_configuration.cpp.o] Error 1

if it disables this line in Marlin \ src \ lcd \ menu \ menu_configuration.cpp

// EDIT_ITEM (float42_52, MSG_IDEX_DUPE_GAP, & duplicate_extruder_x_offset);

FW can be compiled

@thinkyhead thinkyhead merged commit e955dce into MarlinFirmware:bugfix-2.0.x Nov 16, 2020
FhlostonParadise pushed a commit to FhlostonParadise/Marlin that referenced this pull request Nov 21, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Kannix2005 pushed a commit to Kannix2005/Marlin-1 that referenced this pull request Dec 7, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
@InsanityAutomation InsanityAutomation deleted the IdexUsabilityTweaks branch April 3, 2021 15:22
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants