Fix runout sensor for mixing extruder #20327
Conversation
…d %t parameter to FILAMENT_RUNOUT_SCRIPT.
Marlin/src/feature/runout.h
Outdated
| return runout_mm_countdown[active_extruder] < 0; | ||
| static inline uint8_t has_run_out() { | ||
| uint8_t sensor_bitmask = 0; | ||
| LOOP_L_N(i, NUM_RUNOUT_SENSORS) if (runout_mm_countdown[i] < 0) SBI(sensor_bitmask, i); |
There was a problem hiding this comment.
Also seems to ignore whether your feature is enabled?
There was a problem hiding this comment.
This applies to everything below this in the file also.
There was a problem hiding this comment.
The state is checked for all sensors, however a runout is only triggered for the active extruder / sensor or when WATCH_ALL_RUNOUT_SENSORS is enabled.
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
|
Is the runout sensor issue now fixed for the likes of A20T? The runout sensor didn't work. |
Description
Fixing runout sensor to use actually triggering extruder / sensor. The actual (virtual) extruder cannot be used with mixing setup as it is not necessarily mapping to a single extruder.
The triggering sensor can now be used as parameter (%t) for the
FILAMENT_RUNOUT_SCRIPT.e.g.
"M600 T%t"Benefits
Enables runout sensors and runout script for mixing extrude setup.
Configurations
Configuration.h /
FILAMENT_RUNOUT_SENSORsection:WATCH_ALL_RUNOUT_SENSORS: Triggers runout script for all sensors (not only the one for the active sensor). This is automatically enabled forMIXING_EXTRUDER.Related Issues
Related to bug report #19877