Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds extruder stepper disable back to filament unload procedure #20346

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Adds extruder stepper disable back to filament unload procedure #20346

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7716ae1
Adds extruder stepper disable back to filament unload procedure
thebelin Dec 1, 2020
0e6b78b
Explain why it's bad
thinkyhead Dec 2, 2020
90f4909
Update pause.cpp
thinkyhead Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions Marlin/src/feature/pause.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,18 @@ bool load_filament(const float &slow_load_length/*=0*/, const float &fast_load_l
return true;
}

/**
* Disabling E steppers for manual filament change should be fine
* as long as users don't spin the E motor ridiculously fast and
* send current back to their board, potentially frying it.
*/
inline void disable_active_extruder() {
#if HAS_E_STEPPER_ENABLE
disable_e_stepper(active_extruder);
safe_delay(100);
#endif
}

/**
* Unload filament from the hotend
*
Expand Down Expand Up @@ -357,11 +369,8 @@ bool unload_filament(const float &unload_length, const bool show_lcd/*=false*/,
planner.settings.retract_acceleration = saved_acceleration;
#endif

// Disable E steppers for manual change
#if HAS_E_STEPPER_ENABLE
disable_e_stepper(active_extruder);
safe_delay(100);
#endif
// Disable the Extruder for manual change
disable_active_extruder();

return true;
}
Expand Down Expand Up @@ -447,6 +456,9 @@ bool pause_print(const float &retract, const xyz_pos_t &park_point, const float
set_duplication_enabled(saved_ext_dup_mode, saved_ext);
#endif

// Disable the Extruder for manual change
disable_active_extruder();

return true;
}

Expand Down