Custom build_flags by feature #20692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpruvot
reviewed
Jan 6, 2021
| @@ -132,8 +132,7 @@ def force_ignore_unused_libs(): | |||
| known_libs = get_all_known_libs() | |||
| diff = (list(set(known_libs) - set(env_libs))) | |||
| lib_ignore = env.GetProjectOption('lib_ignore') + diff | |||
| if verbose: | |||
| print("Ignore libraries:", lib_ignore) | |||
| blab(f'Ignore libraries: {lib_ignore}') | |||
There was a problem hiding this comment.
Please note this syntax breaks python 2.7 support. Maybe a python version check should be done before ? to avoid weird errors later...
There was a problem hiding this comment.
the problem is not i dont use python3 but ubuntu 18.04 and fedora 29 (at least) symlink "python" to python2 by default
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
susisstrolch
pushed a commit
to susisstrolch/Marlin
that referenced
this pull request
Jan 8, 2021
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (105 commits) [cron] Bump distribution date (2021-01-08) Fix M48 output (MarlinFirmware#20713) Improved MKS Robin support (MarlinFirmware#19333) Preheat before Power Loss Recovery homing (MarlinFirmware#20697) [cron] Bump distribution date (2021-01-07) Custom build_flags by feature (MarlinFirmware#20692) [cron] Bump distribution date (2021-01-06) Multi-Z stepper inverting (MarlinFirmware#20678) Fix Azteeg X3 macro typo (MarlinFirmware#20681) Define SANGUINOLOLU 1.1 enable pins (MarlinFirmware#20682) No BTN_ENC_EN on Anet 10 (MarlinFirmware#20684) Temperature report followup (MarlinFirmware#20687) Adjustable precision in M105 temperature report (MarlinFirmware#20602) Don't apply hotend_offset.z to Z soft endstops (MarlinFirmware#20675) Indent tool_change_prime Clarify solenoid active / magnet-on state Defer "quiet probing" till the last Z bump (MarlinFirmware#20610) Solenoid cleanups [cron] Bump distribution date (2021-01-05) Remove untranslated strings ...
tpruvot
added a commit
to tpruvot/Marlin
that referenced
this pull request
Jan 8, 2021
blab(f'str') requires Python 3.6... adapt for both...
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
Fix regression from MarlinFirmware#20692
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
Fix regression from MarlinFirmware#20692
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
Fix regression from MarlinFirmware#20692
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
Fix regression from MarlinFirmware#20692
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
added a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the capability to customize build flags for an environment based on enabled features. In support of PR #20492 Postmortem Debugging.
Usage
Add a
custom_marlin.FEATUREentry to any environment inplatformio.iniand includebuild_flags=in the line. On build the specified flags will be added onto the existing build flags.