Wanhao One+ SD detect pin #20724
Merged
Wanhao One+ SD detect pin #20724
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
changed the title
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Define SD_DETECT_PIN for Wanhao One+ board to enable SD card support.
Benefits
Prior to this Marlin was not detecting SD card insertion on a Cocoon Create ModelMaker (a Wanhao Duplicator i3 Mini rebrand).
Configurations
This allows Configuration.h's SDSUPPORT define to function as expected:
Related Issues
Additional Information
An old Cocoon Create ModelMaker joined the printer family this week. After backing up Marlin 1.1.4 and upgrading to 2.0.7.2 it was observed that the SD card was no longer working. Continuity probing showed the Card Detect connected to m2560 pin 49 which, in src/HAL/AVR/fastio/fastio_1280.h maps to Port D6/Logical Pin 83.