Fix AutoReporter not building and not working #20959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2021
X-Ryl669
changed the title
thinkyhead
reviewed
Jan 31, 2021
rhapsodyv
reviewed
Jan 31, 2021
This was
linked to
issues
Jan 31, 2021
Closed
|
Here it is, no inheritance, plain old static method calling. |
|
Thanks! Looks like we arrived at about the exact same code. |
Jyers
pushed a commit
to Jyers/Marlin
that referenced
this pull request
Feb 3, 2021
susisstrolch
pushed a commit
to susisstrolch/Marlin
that referenced
this pull request
Feb 16, 2021
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (121 commits) [cron] Bump distribution date (2021-02-04) [cron] Bump distribution date (2021-02-03) Add "more" menu in LVGL interface (MarlinFirmware#20940) Evaluate ANY_SERIAL_IS in place Note (MarlinUI) limit on PREHEAT settings (MarlinFirmware#20966) Update a UBL comment (MarlinFirmware#20931) STM32 Shared Media - USB Mass Storage Device (MarlinFirmware#20956) Multi-language pertains to Color UI (MarlinFirmware#20972) Touch Calibration Screen auto-save option (MarlinFirmware#20971) Include ui_common for MARLIN_LOGO_FULL_SIZE (MarlinFirmware#20963) Fix host_response_handler compile (MarlinFirmware#20962) [cron] Bump distribution date (2021-02-02) LVGL UI G-code console (MarlinFirmware#20755) [cron] Bump distribution date (2021-02-01) Refresh screen on M22 (detach) (MarlinFirmware#20958) Fix AutoReporter implementation (MarlinFirmware#20959) Serial refactor followup (MarlinFirmware#20932) Init serial ports first (MarlinFirmware#20944) Remove extra G29 V newlines (MarlinFirmware#20955) [cron] Bump distribution date (2021-01-31) ...
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Newly added AutoReporter class does not build correctly when MULTI_SERIAL is enabled.
Also, it does not work since it the base class is not using a virtual auto_report method.
This PR fix both issue (I hope, I don't have any printer with those)
I'm not using a virtual table for the cost it has, but CRTP again, so it should be optimal.
Fix #20921 and #20913.
Requirements
Board from #20921
Configurations
Don't have
Related Issues
#20921