Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'H' value for UBL G29 z-clearance #21114

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

slowbro
Copy link
Member

@slowbro slowbro commented Feb 17, 2021

Description

Using UBL, G29 P2 allows you to manually probe points on the bed; the G29 command also accepts an H argument so that the user can specify the Z-height that the nozzle will be lowered/raised to between probes. Currently, specifying H does not work with P2 - it always goes back to the Z_CLEARANCE_BETWEEN_PROBES.

Requirements

UBL enabled, LCD required.

Benefits

Fixes the Z behavior in P2 to match the documentation, respecting the user-provided H value. Also outputs more clear instructions to the LCD screen (instead of staying on 'Moving to next point').

Existing behavior:

  1. G29 P2 H1 T
  2. Nozzle moves to an invalid mesh point
  3. Nozzle is lowered to 1mm (from H)
  4. Nozzle is re-raised to Z_CLEARANCE_BETWEEN_PROBES (5mm)
  5. User is prompted on LCD with "Moving to next point"

Fixed Behavior:

  1. G29 P2 H1 T
  2. Nozzle moves to an invalid mesh point
  3. Nozzle is lowered to 1mm
  4. User us prompted with LCD message "Measure"

Configurations

An example configuration would enable UBL, EEPROM_SETTINGS, and an LCD.

diff --git a/Marlin/Configuration.h b/Marlin/Configuration.h
index 428e899b33..3f4b2e6994 100644
--- a/Marlin/Configuration.h
+++ b/Marlin/Configuration.h
@@ -1313,7 +1313,7 @@
 //#define AUTO_BED_LEVELING_3POINT
 //#define AUTO_BED_LEVELING_LINEAR
 //#define AUTO_BED_LEVELING_BILINEAR
-//#define AUTO_BED_LEVELING_UBL
+#define AUTO_BED_LEVELING_UBL
 //#define MESH_BED_LEVELING
 
 /**
@@ -1588,7 +1588,7 @@
  *   M501 - Read settings from EEPROM. (i.e., Throw away unsaved changes)
  *   M502 - Revert settings to "factory" defaults. (Follow with M500 to init the EEPROM.)
  */
-//#define EEPROM_SETTINGS     // Persistent storage with M500 and M501
+#define EEPROM_SETTINGS     // Persistent storage with M500 and M501
 //#define DISABLE_M503        // Saves ~2700 bytes of PROGMEM. Disable for release!
 #define EEPROM_CHITCHAT       // Give feedback on EEPROM commands. Disable to save PROGMEM.
 #define EEPROM_BOOT_SILENT    // Keep M503 quiet and only give errors during first load
@@ -2187,7 +2187,7 @@
 // This is RAMPS-compatible using a single 10-pin connector.
 // (For CR-10 owners who want to replace the Melzi Creality board but retain the display)
 //
-//#define CR10_STOCKDISPLAY
+#define CR10_STOCKDISPLAY
 
 //
 // Ender-2 OEM display, a variant of the MKS_MINI_12864

Related Issues

No issue open for this; fixed directly & made PR. Didn't see any matching open issues.

@slowbro
Copy link
Member Author

slowbro commented Feb 24, 2021

Rebased as the changes conflicted with bdb8c07

@thinkyhead thinkyhead changed the title Fix UBL G29 manual probing not respecting H option for Z-clearance height Use 'H' value for UBL G29 z-clearance Feb 25, 2021
@thinkyhead thinkyhead merged commit a21d4c0 into MarlinFirmware:bugfix-2.0.x Feb 25, 2021
vyacheslav-shubin pushed a commit to vyacheslav-shubin/Marlin that referenced this pull request Mar 10, 2021
vyacheslav-shubin pushed a commit to vyacheslav-shubin/Marlin that referenced this pull request Mar 10, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
@slowbro slowbro deleted the g29-p2-zheight branch June 28, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants