bug: Invalid PlatformIO option for memory offset #22017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subset of STM32F1 & STM32F4 board definitions are using the option `board_build.address` to specifying the memory location for firmware. The correct option to be used is `board_upload.offset_address`, which was added in [platformio/platform-ststm32#853208d1][1]. PR MarlinFirmware#21488 (recently submitted) uses the correct option for some _newly_ added hardware abstractions, but left this in place for existing hardware. Using this option presently overwrites the bootloader when using `openocd` and an STLinkV2. For example: https://ask.csdn.net/questions/4185515 This is occurring because the option gets ignored and the default vector table location of `0x08000000` gets used (which is the location of the bootloader). NOTE: All changes were made using the following mechanism ```bash sed -i 's/board_build.address/board_upload\.offset_address/g' ini/stm32f{1,4}.ini ``` No other changes to spacing or validation beyond verification on the STM32F103RE_btt board. This is confirmed operational with the offset previously used with the invalid option, `0x08007000`. [1]: platformio/platform-ststm32@853208d1
brianredbeard
commented
Jun 1, 2021
|
That value is there for use by #
# buildroot/share/PlatformIO/scripts/custom_board.py
#
import marlin
board = marlin.env.BoardConfig()
address = board.get("build.address", "")
if address:
marlin.relocate_firmware(address)
ldscript = board.get("build.ldscript", "")
if ldscript:
marlin.custom_ld_script(ldscript) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A subset of STM32F1 & STM32F4 board definitions are using the option
board_build.addressto specifying the memory location for firmware.The correct option to be used is
board_upload.offset_address, whichwas added in platformio/platform-ststm32#853208d1. PR #21488
(recently submitted) uses the correct option for some newly added
hardware abstractions, but left this in place for existing hardware.
Using this option presently overwrites the bootloader when using
openocdand an STLinkV2.For example: https://ask.csdn.net/questions/4185515
This is occurring because the option gets ignored and the default vector
table location of
0x08000000gets used (which is the location of thebootloader).
NOTE: All changes were made using the following mechanism
sed -i 's/board_build.address/board_upload\.offset_address/g' ini/stm32f{1,4}.iniNo other changes to spacing or validation beyond verification on the
STM32F103RE_btt board. This is confirmed operational with the offset
previously used with the invalid option,
0x08007000.Requirements
STM32
Benefits
Users with conforming boards should be able to upload directly using OpenOCD without obliterating their bootloader (though it seems this should, long term, really be added to the processor definition as opposed to individual boards).
Related Issues
Affects: