-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set XATC default start and spacing values in reset() #23839
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…htly faster convergence on target temperature
Including X universal axis twist compensation
…th default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should have been part of setting the default XATC values in #23828. Without these values, XATC does not work and either the wizard must be run or config must be loaded from EEPROM. i.e. this PR allows XATC to work with default values without EEPROM.
Also set XATC to enabled in reset() because defaults values will either have no effect (for a virgin
Configuration_adv.h
) or will have the effect explicitly configured byConfiguration_adv.h
.Requirements
Some kind of auto bed leveling and an X axis which is subject to twist.
Configurations
#define X_AXIS_TWIST_COMPENSATION
Related Issues
#23828