Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the target file before renaming #24008

Closed
wants to merge 1 commit into from
Closed

remove the target file before renaming #24008

wants to merge 1 commit into from

Conversation

robbycandra
Copy link
Contributor

remove the target file before renaming the firmware

@thisiskeithb
Copy link
Member

Wouldn’t the fix from #24001 work just as well?

@robbycandra
Copy link
Contributor Author

Hi @thisiskeithb,
I didn't aware that there was already a fix for that. Thanks for your comment. Let's use PR #24001.

@robbycandra robbycandra closed this Apr 7, 2022
@robbycandra robbycandra deleted the Remove_target_file_before_rename branch April 10, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbycandra @thisiskeithb