Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autotemp to eeprom settings #25093

Merged
merged 9 commits into from
Dec 31, 2022
Merged

add autotemp to eeprom settings #25093

merged 9 commits into from
Dec 31, 2022

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Dec 13, 2022 •
edited by thinkyhead
Loading

Description

Save auto temp settings to eeprom

Requirements

AUTOTEMP, EEPROM_SETTINGS and a LCD to let you edit the values.

Benefits

Settings can be saved

Configurations

NOTE the following are now exposed in Configuration_adv.h vs being hidden in Marlin/src/module/planner.cpp

  #define AUTOTEMP_MAX        250
  #define AUTOTEMP_MIN        210
  #define AUTOTEMP_FACTOR       0.1f
  #define AUTOTEMP_ENABLED  false

Related Issues

Feature request #25082

Questions?

I feel this really should be settable in gcode and displayed in m503... Thoughts?
not just a parameter of M104/9

@ellensp ellensp added Needs: Testing Testing is needed for this change PR: New Feature labels Dec 13, 2022
@ellensp ellensp mentioned this pull request Dec 13, 2022
Closed
1 task
@thisiskeithb
Copy link
Member

Autotemp is calculated by (mintemp + factor * mm_per_sec), capped to maxtemp.

Shouldn’t this be capped to the actual E max temp instead of 250 (AUTOTEMP_MAX)?

It’d remove an extra define at least.

@ellensp
Copy link
Contributor Author

ellensp commented Dec 13, 2022

AUTOTEMP_MAX could be lower than max_temp. so it needs to be there

thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Dec 18, 2022
@thinkyhead
✨ AUTOTEMP options
0a5b3c5 
MarlinFirmware/Marlin#25093
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Dec 18, 2022
@thinkyhead
✨ AUTOTEMP options
80837fd 
MarlinFirmware/Marlin#25093
@thinkyhead thinkyhead merged commit c7e84e8 into MarlinFirmware:bugfix-2.1.x Dec 31, 2022
@ellensp ellensp deleted the autotemp-settings branch December 31, 2022 04:08
@thisiskeithb thisiskeithb mentioned this pull request Jan 12, 2023
Closed
1 task
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Feb 22, 2023
@ellensp @thinkyhead
✨ Persistent AUTOTEMP settings (MarlinFirmware#25093)
9609c2d
thinkyhead pushed a commit that referenced this pull request Apr 10, 2023
@ellensp @thinkyhead
✨ Persistent AUTOTEMP settings (#25093)
afe8a6e
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request May 16, 2023
@ellensp @thinkyhead
✨ Persistent AUTOTEMP settings (MarlinFirmware#25093)
515b71d
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
@ellensp
✨ Persistent AUTOTEMP settings (MarlinFirmware#25093)
62696d8
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 2, 2023
@ellensp @Andy-Big
✨ Persistent AUTOTEMP settings (MarlinFirmware#25093)
afe5ecb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs: Testing Testing is needed for this change PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellensp @thisiskeithb @thinkyhead