Assisted tramming can handle up to 9 points. #25293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
40e1292 to
339773d
Compare
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Feb 21, 2023
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
LMBernardo
pushed a commit
to LMBernardo/Marlin
that referenced
this pull request
Mar 19, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 7, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
Apr 8, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 10, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
May 16, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have implemented the support for assisted tramming of up to 9 points (previously 6).
In code:
Configuration_adv.htramming.hppI have modified the checks whether there is equal number of points and names and validation of positions agains probe safe zone, declaration of point_name constants and point count constant.tramming.cppI have extended the#ifdefhell in the constants' assignment and creation of points array.Requirements
No.
Benefits
Assisted tramming was able to handle between 3 to 6 points. That is insufficient because if you have a bed that is too big for 4 adjustment screws (I think tramming over screws is the most effective), the next logical step is to have 9 adjustment screws (grid 3x3). Therefore 9 tramming points.
Configurations
Not needed.
Feedback
My preprocessor skills are a bit rusty. Initially I wanted to allow for arbitrary number of tramming points using some sort of loop or recurvively expanding macros but as far as I know that is not possible. Is that true?