-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply const_float_t for AVR #25716
base: bugfix-2.1.x
Are you sure you want to change the base?
Apply const_float_t for AVR #25716
Conversation
"makes a bug difference" foreshadowing? |
The cogent exploration here is whether The old advice was that function calls are faster/smaller because it only requires 2 bytes on AVR to pass a In testing the difference tonight, the code size is 90 bytes smaller using the An isolated test shows no apparent code size difference when passing by value or by reference, but I have not yet looked at the assembler output to compare the difference in the resulting assembler code. If the AVR compiler has become smarter and can find the best balance of faster/smaller then the |
8aac7b6
to
7e515e2
Compare
7e515e2
to
e370838
Compare
0306534
to
205da4d
Compare
205da4d
to
c8e41c4
Compare
c8e41c4
to
5829dea
Compare
1bb6412
to
56d7511
Compare
c624e13
to
e6f1b07
Compare
56d7511
to
6f22a80
Compare
9c65146
to
4f65466
Compare
c792921
to
37fb26b
Compare
0f1df8b
to
37d77d6
Compare
37d77d6
to
aa44542
Compare
6f22a80
to
38903f7
Compare
Since AVR has 16-bit pointers some calls and code size may be optimized using a
const float&
instead of aconst float
. Whether this makes a big difference in practice is yet to be widely tested, but this PR appliesconst_float_t
for consistency anyway.