Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui.quick_feedback() error in G26 #25725

Conversation

marciot
Copy link
Contributor

@marciot marciot commented Apr 21, 2023

Description

Fix for the following compilation errors due to missing TERN statements.

src/gcode/bedlevel/G26.cpp:329:12: error: ‘class MarlinUI’ has no member named ‘quick_feedback’
         ui.quick_feedback();
            ^
src/gcode/bedlevel/G26.cpp:346:8: error: ‘class MarlinUI’ has no member named ‘quick_feedback’
     ui.quick_feedback();
        ^
src/gcode/bedlevel/G26.cpp:354:8: error: ‘class MarlinUI’ has no member named ‘completion_feedback’
     ui.completion_feedback();
        ^
src/gcode/bedlevel/G26.cpp: In member function ‘bool<anonymous struct>::prime_nozzle()’:
src/gcode/bedlevel/G26.cpp:407:10: error: ‘class MarlinUI’ has no member named ‘quick_feedback’
       ui.quick_feedback();
          ^
make: *** [Makefile:1008: applet/src/gcode/bedlevel/G26.o] Error 1

@thisiskeithb
Copy link
Member

Would #25720 work instead?

@marciot
Copy link
Contributor Author

marciot commented Apr 21, 2023

Would #25720 work instead?

Yes, it would. I guess I will let @thinkyhead decide which fix is better. There already are some other instances of ui.quick_feedback() individually wrapped in TERN statements, so it seems like there are competing solutions to this particular problem.

@thinkyhead
Copy link
Member

The usage of quick_feedback (among other things) could use some rework generally. I would recommend separating concepts like the status message, audio feedback, etc. which are under the umbrella of MarlinUI into more granular concepts as we continue to modernize and clean up this elaborating codebase.

@thinkyhead thinkyhead closed this Apr 22, 2023
@thinkyhead thinkyhead deleted the pr-ui-quick-feedback-g26-fix branch April 22, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants