invert all Z stepper when needed #25798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
dual-z-direction
branch
from
fb29159 to
1686ce3
Compare
thinkyhead
force-pushed
the
dual-z-direction
branch
from
1686ce3 to
802e74a
Compare
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
May 11, 2023
oponyx
pushed a commit
to oponyx/Marlin
that referenced
this pull request
May 12, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 15, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Andy-Big
added a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 17, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when you set INVERT_Z_DIR true with multiple steppers drivers, only Z1 gets inverted
The code looks good, but INVERT_Z2_DIR, INVERT_Z3_DIR and INVERT_Z4_DIR are not set when needed
Added these defines as required
Requirements
Multiple Z stepper drivers with INVERT_Z_DIR
Benefits
INVERT_Z_DIR inverts all active Z stepper drivers as expected
Related Issues
#25794