update goto_edit_screen Initial encoder value data size #25812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oponyx
pushed a commit
to oponyx/Marlin
that referenced
this pull request
May 14, 2023
oponyx
pushed a commit
to oponyx/Marlin
that referenced
this pull request
May 14, 2023
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 15, 2023
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue #23849
If you have a large number of steps/mm (a common example is 1600 for Z)
If you use the advanced menu|edit steps/mm. On the menu screen this shows 1600, but the instant you enter the menu to edit the value, 1600 changes to a much smaller number.
Found that goto_edit_screen ep was being overflowed
Upgraded from uint16_t to uint32_t and the issue is resolved.
Requirements
128x64 LCD
Marlin menu.
Benefits
Steps/mm edit menu works as expected on larger numbers.
Related Issues
#25806
#23849