Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to SPI0 with YHCB2004 #25856

Merged
merged 2 commits into from
May 21, 2023

Conversation

thinkyhead
Copy link
Member

The YHCB2004 display appears to have a bad initialization and hacks "DIO" pins to reassign its SPI port pins.

This PR removes the use of "DIO" defined pins in FastIO headers and directly assigns the YHCB2004 display SPI pins.

@thinkyhead thinkyhead merged commit ae3b00d into MarlinFirmware:bugfix-2.1.x May 21, 2023
@thinkyhead thinkyhead deleted the bf2_YHCB2004_PR branch May 21, 2023 22:35
ncksnydr added a commit to ncksnydr/Narungol-Marlin-Firmware that referenced this pull request May 22, 2023
… into feature/bugfix-2.1.x

* 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin: (61 commits)
  🔨 Fix BTT EBB42 V1.1 compile with -flto (MarlinFirmware#25849)
  [cron] Bump distribution date (2023-05-22)
  🧑‍💻 Fall back to SPI0 with YHCB2004 (MarlinFirmware#25856)
  🩹 Fix ProUI Manual Mesh / UBL Viewer (MarlinFirmware#25858)
  🩹 Fix TFT LVGL compile error (MarlinFirmware#25865)
  [cron] Bump distribution date (2023-05-21)
  📝 MKS TinyBee pins header
  🚸 Improve EEPROM validation (MarlinFirmware#25860)
  [cron] Bump distribution date (2023-05-20)
  🎨 Cutter pins cleanup
  [cron] Bump distribution date (2023-05-19)
  🩹 M493 report followup
  ✨ I3DBEEZ9 board (MarlinFirmware#25614)
  🔨 Fix Windows path backslash treated as escape
  [cron] Bump distribution date (2023-05-18)
  🚸 Unify edit limits for some E3V2 LCDs (MarlinFirmware#25045)
  [cron] Bump distribution date (2023-05-17)
  🐛 Fix MKS Robin Nano 1.3 F4 pin collision (MarlinFirmware#25838)
  🚸 Support Bed Leveling Mesh > 16x16
  🔧 TMC Config Inheritance followup (MarlinFirmware#25783)
  ...

Signed-off-by: Nick Snyder <nick@nicksnyder.is>

# Conflicts:
#	config/ncksnydr/narungol/2.1/Configuration.h
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
@oponyx
Copy link
Contributor

oponyx commented May 29, 2023

Hi, doesn't work on Gt2560V4.1b board (blank display).
@thinkyhead Please fix by approving PR #25888
Thanks

Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 15, 2023
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants