Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Mellow Fly E3 Pro V3 (STM32F407VG) #26214

Draft
wants to merge 17 commits into
base: bugfix-2.1.x
Choose a base branch
from
Draft

✨Mellow Fly E3 Pro V3 (STM32F407VG) #26214

wants to merge 17 commits into from
+595 −3

Conversation

jaysuk
Copy link
Contributor

@jaysuk jaysuk commented Aug 30, 2023 •
edited by thisiskeithb
Loading

Description

Based on the Fly-E3-v2 mainboard that was merged into Marlin, this is for the Fly-E3-Pro-V3

Requirements

A Fly-E3-Pro-V3

Benefits

Adds support for the Fly-E3-Pro-V3 board

Configurations

Related Issues

None

@thisiskeithb
Copy link
Member

thisiskeithb commented Aug 30, 2023 •
edited
Loading

Since this is a duplicate PR, it'd be better to send PRs to #25894 / https://github.com/IoakeimSogiakas/Marlin/tree/FLY_RRF_MARLIN

@jaysuk
Copy link
Contributor Author

jaysuk commented Sep 3, 2023

i've sent a message to the author but not heard anything back.
can we not just merge this one and close the other PR?

@ellensp ellensp mentioned this pull request Sep 3, 2023
Closed
@thisiskeithb
Copy link
Member

can we not just merge this one and close the other PR?

That’s not how it generally works. Users collaborate via a single PR/fork, not open multiple PRs.

@ellensp
Copy link
Contributor

ellensp commented Sep 3, 2023

PR #25894 closed, superseded with this on of this one

@thisiskeithb
Copy link
Member

I guess that settles that.

@ellensp
Copy link
Contributor

ellensp commented Sep 3, 2023 •
edited
Loading

original pr was not finished and seems to be abandoned. this is a step forward

@jaysuk
Copy link
Contributor Author

jaysuk commented Sep 3, 2023

@ellensp thanks

@jaysuk
Copy link
Contributor Author

jaysuk commented Sep 5, 2023

As far as I'm concerned this is ready to merge

@jaysuk
Copy link
Contributor Author

jaysuk commented Sep 15, 2023

anything else i need to do with this?

@ellensp
Copy link
Contributor

ellensp commented Sep 15, 2023

be patent, main developer is taking a break for an unknown period of time

@sjasonsmith
Copy link
Contributor

@jaysuk can you update this to work with the latest bugfix-2.1.x and push new changes? If so we should be able to do a final review of this and get it in soon.

@jaysuk
Copy link
Contributor Author

jaysuk commented Nov 21, 2023 •
edited
Loading

@sjasonsmith updated to the latest. only had to change the boards file

@thisiskeithb
Copy link
Member

I also just pushed 55a109e to fix a few small things in pins_MELLOW_FLY_E3_PRO_V3.h.

@jaysuk
Copy link
Contributor Author

jaysuk commented Nov 21, 2023

thanks, didn't even think to check those. Once this is merged I will move on to the next board. I still have the Fly-CDYv3 and Super8 boards to do in the F4 range. Then its on to the H7 ones

@thisiskeithb
Run pinsformat.js
7b8b522
@thisiskeithb
Shrink BOARD_INFO_NAME
c3761b2 
Should be ≤ 20 chars to prevent cutoff
@sjasonsmith sjasonsmith self-assigned this Nov 21, 2023
sjasonsmith
sjasonsmith reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@sjasonsmith sjasonsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this supports a lot of peripherals with custom pinouts, such as motor expanders and various temperature sensors.

How confident are you that all of these are correct for this board?

ini/stm32f4.ini Outdated Show resolved Hide resolved
@jaysuk
Copy link
Contributor Author

jaysuk commented Nov 21, 2023

i checked all the pins against the pinouts of the modules etc.
i maintain all the docs for the RRF port so i know the boards "fairly" well

@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 2 times, most recently from 9c65146 to 4f65466 Compare January 26, 2024 00:13
@sjasonsmith sjasonsmith removed their assignment Apr 7, 2024
@thisiskeithb thisiskeithb changed the title Add Mellow-Fly-E3-Pro-V3 ✨Mellow Fly E3 Pro V3 (STM32F407VG) Apr 25, 2024
@thisiskeithb
Copy link
Member

PR has been brought up to date & I've pushed some more updates to pins_MELLOW_FLY_E3_PRO_V3.h. See my question above about flash drive support.

@thisiskeithb
More pin updates
fda99f5 
* Add DIAG jumper flag
* Assert TMC2209 defaults
* Update SDCARD connection format
@thisiskeithb
Copy link
Member

thisiskeithb commented Apr 25, 2024 •
edited
Loading

I just discovered this note about the Mellow Fly E3 Pro V3's thermistor pull-ups:

Important

The Fly-E3-Pro-v3 uses a 2k2 resistor on the thermistor inputs rather than 4k7. Please make sure you add R2200 to each M308 in your config

I ran into this while working on LDO Leviathan board support and it means that users will have select thermistor 1000 for any thermistor they want to use and will have to define all the custom thermistor 1000 parameters found in Configuration_adv.h since Marlin assumes 4.7K as the default pull-up type for most thermistors.

I also saw the note about needing to add jumpers on Z2's output (I assume they are driven in series?), so adding a warning to the pins file would be a good idea.

@thisiskeithb thisiskeithb marked this pull request as draft April 25, 2024 15:52
@thisiskeithb thisiskeithb added Needs: Work More work is needed Needs: Discussion Discussion is needed labels Apr 25, 2024
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 37d77d6 to aa44542 Compare September 28, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisiskeithb thisiskeithb thisiskeithb left review comments

@sjasonsmith sjasonsmith sjasonsmith left review comments

Assignees
No one assigned
Labels
A: STM32 C: Boards/Pins Needs: Discussion Discussion is needed Needs: Work More work is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaysuk @thisiskeithb @ellensp @sjasonsmith