add Repeat get functions, fixes issue 26357 #26367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasToka
added a commit
to ThomasToka/Marlin
that referenced
this pull request
Oct 24, 2023
thinkyhead
force-pushed
the
issue-26357
branch
from
f8ecde6 to
9c15297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#define GCODE_REPEAT_MARKERS
with
#define DEBUG_POWER_LOSS_RECOVERY
Fails to compile as DEBUG_POWER_LOSS_RECOVERY attempts to display private variables in class Repeat
Added get functions to return the private variables
Requirements
In Config enable
#define SDSUPPORT
#define POWER_LOSS_RECOVERY
#define GCODE_REPEAT_MARKERS // Enable G-code M808 to set repeat markers and do looping
In powerloss.h enable
#define DEBUG_POWER_LOSS_RECOVERY
Benefits
Builds as expected
Configurations
See Requirements
Related Issues
#26357