SKR Pro boards have no DIAG jumpers #26399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has needs USES_DIAG_PINS does not have jumpers
|
Every time I do a PR CI is broken!!! This is most frustrating! |
__FLT_MAX__ not FLT_MAX
|
Fixed |
ellensp
changed the title
remove spaces
|
Since PR is still open, I've add a commit remove a erroneous indent in pins.h |
thinkyhead
changed the title
eoyilmaz
pushed a commit
to eoyilmaz/Marlin
that referenced
this pull request
Nov 21, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
and defines USES_DIAG_JUMPERS
Both of these board do not have diag jumpers and require cutting off the diag pins if not using sensorless homing.
Updated to use USES_DIAG_PINS
FLT_MAXused when it should be__FLT_MAX__Requirements
BOARD_BTT_SKR_PRO_V1_1 or BOARD_BTT_SKR_PRO_V1_2
Benefits
Correct warning is given
"Driver DIAG pins must be physically removed unless SENSORLESS_HOMING is enabled. (See https://bit.ly/2ZPRlt0) (Define DIAG_PINS_REMOVED to suppress this warning.)"
Configurations
Related Issues