Follow up to "🚸 Update ProUI Plot graph (#26539)"

[classicrocker883]

Description

I wanted to make an update following #26539

• update ProUI for additional ICON_'s for new DWIN_SET
• update temp popup
• remove unused,
• rearrange/change ICON_ names
• rearrange enum PauseMessage
• add TJC support

Update

• update DWIN_ICO.py
• add extra ICON_'s to buildroot/share/dwin
• rename DACAI_ICON_Show => dacaiIconShow | ICON_Show => iconShow

I made a fix for this issue "[BUG] Unresponsive display with Hotend/Bed Temp Graph - PROUI_ITEM_PLOT #26630 "

• Update ID_MPC/PIDProcess with TERN_
• Fix Plot Temp Graph issue by making it return screen if there is a popup

Benefits

this updates proui/dwin.cpp menu ICON's with more variety.

• fixes some things that are unused and duplicates
• tweak it to be arranged better

Configurations

Related Issues

for the added EXTUI, I made some fixes to the errors which popped up.

• reverted allow_cold_extrude_override in src/module/temperature.cpp (which was removed??)
• fixed the no such file errors in moved lcd/dogm/u8g/
• various small tweaks to fix errors/warnings since EXTUI stuff was added.

[thinkyhead]

You'll need to rename Icon number 44 in the various icon packs from ICON_ResumeEEPROM to ICON_ResetEEPROM. I renamed this for clarity since it's being used as a stand-in for a more general "reset" icon.

[thinkyhead]

For best compatibility with Marlin's DWIN helper scripts, you'll want to organize custom icon packs into "icons-#" sub-folders with the same numbering and organization as the buildroot/share/dwin folder contents.

[thinkyhead]

What is the procedure to prepare icons 93, 200-206, and 250-254 ? and do these only pertain to TJC? We should add these to buildroot/share/dwin for completeness with our "unified" DWIN set.

[thinkyhead]

I've updated the contents of the buildroot/share/dwin folder, so it should now have everything needed to generate the numbered ICO files for sets 3, 4, and 7. If there's anything missing from that folder, now would be the best time to add the missing pieces.

[classicrocker883]

You'll need to rename Icon number 44 in the various icon packs from ICON_ResumeEEPROM to ICON_ResetEEPROM.

I suppose you mean within this PR here, Configurations #994?
Redoing each one is tedious just to rename one ICON name. I suppose I could do it, but it really doesn't matter with firmware implementation. I would only be able to do it for any labeled DWIN_SET and not for the other TJC "private" or DACAI.

let me know if you want me to do that. otherwise how it is now since you renamed to ICON_ResetEEPROM will be fine.

edit: I just did a test and whatever name you passthrough into creating the .ICO doesn't actually come back out when you split it. but for posterity I can go ahead rename # 44 of the .jpg itself.

[classicrocker883]

What is the procedure to prepare icons 93, 200-206, and 250-254 ? and do these only pertain to TJC? We should add these to buildroot/share/dwin for completeness with our "unified" DWIN set.

*it is actually 249-254

I do not know what others are supported in TJC, same goes for the "private" folder. I guess the same original icons work, but the added ones 93, 200-206, and 249-254 probably do not...

What do you mean by to prepare the icons?

so what I did was take the existing .jpg files, edit them in MS paint, literally pixel by pixel (since it is only 20x20 for the majority of them); remove the "noise" from the background, clean up anything to match the others, fix the loss of quality by the previous editor which happens when saving as .jpg. then I saved it as .png, then used something to convert to .jpg without losing any quality. after going through each one, I followed the instructions how to convert all of them to an .ICO and thats how you get your DWIN_SET.

[classicrocker883]

I've updated the contents of the buildroot/share/dwin folder, so it should now have everything needed to generate the numbered ICO files for sets 3, 4, and 7. If there's anything missing from that folder, now would be the best time to add the missing pieces.

I added the icon packs of the other DWIN_SET's as "icons-9". is this what you were looking for?

[thinkyhead]

I added the icon packs of the other DWIN_SET's as "icons-9". is this what you were looking for?

Not exactly. We're not supporting the original Creality set (icon set 9), only Marlin's (icon sets 3, 4, 7). So I'm just checking to make sure we have all the icons needed for that. It looks like ProUI is now using Icons numbered 93, 200-206, 249-254, so we need the standard icons added to Icon Set 7. I presume that Miguel has already added those icons and created new DWIN_SET / private folders that contain the updated icons for his distribution. We'll need those icons added to our own set 7 in order to support this updated ProUI code.

Note that after we get through this set of changes you should submit any changes we've made to mainline Marlin to the @mriscoc fork so that we are relatively in sync. In the long run it will be better for you to first submit any changes and fixes to that fork, and then we can coordinate with Miguel to bring those changes over en masse to this repo when he reaches a good milestone. The same goes for any other forks that are actively under development.

[convicte]

This seems to have had some unintended consequences breaking LCD support for among others Anycubic Viper

Marlin\src\inc\Warnings.cpp:115:6: warning: #warning "Note: Auto-assigned LCD_SERIAL_PORT. (Define NO_AUTO_ASSIGN_WARNING to suppress this warning.)" [-Wcpp]
  115 |     #warning "Note: Auto-assigned LCD_SERIAL_PORT. (Define NO_AUTO_ASSIGN_WARNING to suppress this warning.)"
      |      ^~~~~~~
Marlin\src\inc\Warnings.cpp:223:6: warning: #warning "Note: Auto-assigned Z2 STEP/DIR/ENABLE_PINs to unused En_STEP/DIR/ENABLE_PINs. (Define NO_AUTO_ASSIGN_WARNING to suppress this warning.)" [-Wcpp]
  223 |     #warning "Note: Auto-assigned Z2 STEP/DIR/ENABLE_PINs to unused En_STEP/DIR/ENABLE_PINs. (Define NO_AUTO_ASSIGN_WARNING to suppress this warning.)"
      |      ^~~~~~~
Marlin\src\inc\Warnings.cpp:760:4: warning: #warning "GD32 based controllers may not be fully compatible with STM32 platforms. Please report any issues." [-Wcpp]
  760 |   #warning "GD32 based controllers may not be fully compatible with STM32 platforms. Please report any issues."
      |    ^~~~~~~
c:/users/.platformio/packages/toolchain-gccarmnoneeabi/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld.exe: .pio/build/trigorilla_v006/src/src/gcode/config/M302.cpp.o: in function `GcodeSuite::M302()':
C:\Users\Documents\GitHub\Marlin/Marlin\src\gcode\config/M302.cpp:54: undefined reference to `ExtUI::onSetMinExtrusionTemp(short)'
collect2.exe: error: ld returned 1 exit status
*** [.pio\build\trigorilla_v006\firmware.elf] Error 1