-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SHOW_CUSTOM_BOOTSCREEN support to HD44780 #26793
Merged
thinkyhead
merged 13 commits into
MarlinFirmware:bugfix-2.1.x
from
ellensp:text-custom-boot-screen
May 19, 2024
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6677362
add SHOW_CUSTOM_BOOTSCREEN support to HD44780
ellensp e92dcf1
move to set_custom_characters
thinkyhead eb27f24
remove PROGMEM
ellensp bd6bb3d
string instead of char array
thinkyhead 2e11274
fix y
thinkyhead 3d56945
handle CHR0
thinkyhead 6b77038
better
thinkyhead b1d5ad3
tweak
thinkyhead ac5baf4
Merge branch 'bugfix-2.1.x' into pr/26793
thinkyhead d649ecf
"character"
thinkyhead 35f8963
oxford
thinkyhead a1a1326
Merge branch 'bugfix-2.1.x' into pr/26793
thinkyhead 9e8348a
currently all
thinkyhead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this flag known also known be needed for macOS? I know we just added it for Windows. Maybe some Linux need it too…?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On current
bugfix-2.1.x
/ without this PR, bothsimulator_macos_debug
andsimulator_macos_release
environments build the default Simulator config fine on my Intel-based Mac.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required on Ubuntu 22.04.4 LTS or Ubuntu 24.04 LTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes macOS needs it, and probably it's ok to use the flag on Linux, or does it complain?