Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MACHINE_KINEMATICS to M115 #26806

Merged

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Feb 20, 2024

Description

Add the machines kinematics to M115
Why? so when you ask the a user did you enable (COREXY, COREZX, SCARA etc) and they respond, "I don't know"
M115 can tell them if the firmware they are running has the required kinematics.

Requirements

M115

Benefits

Visibility of the selected compiled in kinematics.

Related Issues

Had a user on Discord having issue with their COREXY moving diagonally. They had not enabled COREXY on their corexy
M115 could have confirmed this quickly.

@thinkyhead thinkyhead force-pushed the show-kinematics-in-M115 branch from 5dc8eb0 to 76d46d7 Compare March 2, 2024 04:22
@thinkyhead
Copy link
Member

I made some minor adjustments. Use of TERN_ to make the code smaller. And since BELTPRINTER is also CoreXY (but could be something else) I put BELTPRINTER last as an add-on. Maybe a more general suffix like "(Infinite Z)" would be better. But the host can get the size of the Z axis from the Geometry Report, and there might be other things it can do with a "belt" printer, such as setting the number of times to loop through the print, or implementing M808 on the host side.

@thinkyhead thinkyhead merged commit 3fd175a into MarlinFirmware:bugfix-2.1.x Mar 2, 2024
61 checks passed
@ellensp ellensp deleted the show-kinematics-in-M115 branch March 2, 2024 04:42
@kisslorand kisslorand mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants