Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify EMIT_CREALITY_422_WARNING #26826

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Feb 27, 2024

Description

Add hints for *_DRIVER_TYPEs. h/t to @ellensp for the suggestion to simplify the warning further.

Requirements

Creality 4.2.2 motherboard

Benefits

Clearer hint for which *_DRIVER_TYPEs to define.

Related Issues

I don't have a specific issue number, but I've seen this come up on Facebook/Discord/Reddit a lot.

Add hints for *_DRIVER_TYPEs
Accurate driver information is nice, but a simplified warning would be a better approach. A comment with original driver codes has been added for reference.
@thisiskeithb thisiskeithb changed the title Update EMIT_CREALITY_422_WARNING Simplify EMIT_CREALITY_422_WARNING Feb 28, 2024
@thinkyhead thinkyhead merged commit a9e72b2 into MarlinFirmware:bugfix-2.1.x Mar 2, 2024
61 checks passed
@thisiskeithb thisiskeithb deleted the pr/update_EMIT_CREALITY_422_WARNING branch March 2, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants