Fix#2661 Pre home display - Stepper release #2686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also a fix for https://github.com/MarlinFirmware/MarlinDev/issues/238 |
|
Activated the warning about possible reduced accuracy by default Changed the condition for blinking from to |
Wackerbarth
force-pushed
the
RCBugFix
branch
from
645d751 to
e7099ea
Compare
Implement and test blinking for char-lcds
Introduce additional variable axis_homed to replace axix_known_position when the coordinate display should indicate the axis is not homed. This is to distinguish between "not homed" and "inexact position possible because stepper was disabled".
Make stepper shutdown after inactivity dependent on a new set of #defines. DISABLE_INACTIV_X DISABLE_INACTIV_Y DISABLE_INACTIV_Z DISABLE_INACTIV_E And make exemplaric Configuration. Names can be discussed. This makes the disabling of the steppers independent from the DISABLE_? settings witch shut down the steppers immediately.
In the wait loops of M109 M190 idle() is called, what checks stepper_inactive_time against previous_cmd_ms. Because we can be several minutes inside the loop, resetting previous_cmd_ms only outside the loop caused stepper shutdowns. The name of previous_cmd_ms does not really reflect its use. It's set not only when a new command was received or executed but also in many of the movement routines. For that the little extension of using it during the wait will (hopefully) not hurt.
Replaced displaying "---" instead of the value of a coordinate when
unhomed or with reduced precision
with blinking the coordinate-prefix-character ('X','Y','Z').
For "unhomed" a '?' is shown every second second - until that axis is
homed. The value displayed is, as before the "---" where displayed, the
relative to the reset position coordinate value.
When the axis stepper was disabled, now we can display a hint on that,
by showing a blinking '~' instead of the axis letter, when
WARN_REDUCED_ACCURACY is defined.
I suppose the code itself is here the better documentation.
A '+/-' character is in non of our charsets so i decided for a '?' for
now to reduce the work.
There is no additional space on the displays one could use to display
the information, so replacing something is the only option. As the axis
letters are totally redundant with their positions on the display they
contain the least information.
So my decision was to overwrite them.
Exactly the same - copy/paste.
Replaced blinking '~' with ' ' to signalize reduced accuracy. '~' is in close to no of our charsets. ' ' looks a bit cleaner Showing 'Z' for a 'reduced' time may remember to a 'reduced' accuracy.
Refresh previous_cmd_ms during run_z_probe() to prevent: stepper shutdown for expired DEFAULT_STEPPER_DEACTIVE_TIME and extrudes for expired EXTRUDER_RUNOUT_SECONDS (https://github.com/MarlinFirmware/MarlinDev/issues/238)
Renamed `WARN_REDUCED_ACCURACY` to `DISABLE_REDUCED_ACCURACY_WARNING` Changed the condition for blinking from ``` #if ENABLED(WARN_REDUCED_ACCURACY) ``` to ``` #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleaned version of #2676
//#define WARN_REDUCED_ACCURACYis uncommented.what are used in conjunction with
DEFAULT_STEPPER_DEACTIVE_TIME. Disabling the steppers afterDEFAULT_STEPPER_DEACTIVE_TIMEis then independent from theDISABLE_?settings.DISABLE_?configurations then will be used only for the immediate disabling of the steppers when they are not used (buffer empty).Option names can be discussed.
Moving the
DISABLE_?block from 'Configuration.h' to 'Configuration_adv.h' should be considered.You can find some optical examples in #2661
Happy testing.