Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto LCD serial port for MKS Monster8 V1 #26879

Merged

Conversation

narno2202
Copy link
Contributor

Description

Wiring a MKS-H43 screen on Monster8 V1 USART1 port doesn't work because the default serial port isn't the good one: set to 3 instead of 1. The value can't be overridden in Configuration.h by configuring another serial port. Adding MKS_MONSTER8_V1 in Conditionals_adv.h "#if LCD_IS_SERIAL_HOST..."

#if MB(MKS_MONSTER8_V1, BTT_SKR_MINI_E3_V1_0, BTT_SKR_MINI_E3_V1_2, BTT_SKR_MINI_E3_V2_0, BTT_SKR_MINI_E3_V3_0, BTT_SKR_MINI_E3_V3_0_1, BTT_SKR_E3_TURBO, BTT_OCTOPUS_V1_1, AQUILA_V101)
    #define LCD_SERIAL_PORT 1

solve the issue.

Requirements

MKS_MONTER8 V1
MKS_H43 screen (or probably anther DGUS style screen) wired solely on USART 1

Benefits

Screen works as needed

Configurations

Related Issues

@sjasonsmith sjasonsmith requested a review from thisiskeithb April 7, 2024 05:17
@sjasonsmith
Copy link
Contributor

@thisiskeithb it looks like you added this board, does this change seem correct?

I trust that @narno2202's change fixes their use case, but don't know if that is potentially breaking scenarios using other serial ports with different configs.

@thisiskeithb
Copy link
Member

does this change seem correct?

I have no way to test it since my H43 screen has never worked.

narno2202 has the hardware in hand/submitted this PR, so I assume it works.

@sjasonsmith
Copy link
Contributor

I see this on the MKS GitHub page, so it looks like 1 is correct for their intended use-cases:

USART(usart1:PA9,PA10) support [MKS H43](https://www.aliexpress.com/item/1005002008179262.html) or for other serial communication

@sjasonsmith sjasonsmith merged commit d9d7820 into MarlinFirmware:bugfix-2.1.x Apr 7, 2024
61 checks passed
@narno2202 narno2202 deleted the Monster8_serialFix branch April 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants