Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Local URL checking script #26975

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Apr 16, 2024

Add an automated URL checker to run once per week. Subscribe to the action to get notifications.

A script to check URLs in the project. Run periodically to check for broken links. If the script can be made more reliable and to better understand the common use of redirects it might be possible to make into an action to run periodically. So far I have not been able to get it to add comments to this issue from the action, which would be one way to be able to get a notification. That problem seems to be permissions-related.

@thinkyhead thinkyhead added the T: GitHub Admin GitHub actions, templates, website, etc. label Apr 16, 2024
@thisiskeithb
Copy link
Member

thisiskeithb commented Apr 16, 2024

Subscribe to the action to get notifications.

As far as I can tell, there's no way to subscribe to an Action:

image

How do you view the URL(s) that failed? I can only see successful ones with [ OK ] in the log and then the failed message with no prior URL:

image

@sjasonsmith
Copy link
Contributor

@thisiskeithb error show up in there, but they are hard to spot. It would be nice if they were captured in a list and summarized at the end.

image

@thisiskeithb
Copy link
Member

thisiskeithb commented Apr 17, 2024

error show up in there, but they are hard to spot. It would be nice if they were captured in a list and summarized at the end.

Ah, I misunderstood the script and assumed it'd stop after finding a bad URL.


As for "subscribing" to an Action per the Notifications for workflow runs page:

Notifications for scheduled workflows are sent to the user who initially created the workflow. If a different user updates the cron syntax in the workflow file, subsequent notifications will be sent to that user instead.

This will be a thinkyhead-only notification, so it might be better to bump the timeline out to once a month and someone on the team can manually check the logs each time it runs so the workload is spread out.

…or have the script create a new Issue with a list of bad URLs?

Automate all the things!

@thinkyhead
Copy link
Member Author

One "weird" way to get a notification would be to have the action add a comment to an existing issue, then anyone could subscribe to the issue. Might be worth exploring. I'll see if it can add a comment to this issue, for a start.

@thinkyhead thinkyhead force-pushed the bf2_url_check_PR branch 23 times, most recently from e934b9a to 5b180cf Compare April 24, 2024 20:37
@thinkyhead thinkyhead force-pushed the bf2_url_check_PR branch 9 times, most recently from fbe1f65 to 900c462 Compare May 1, 2024 18:07
@thinkyhead thinkyhead force-pushed the bf2_url_check_PR branch 6 times, most recently from df21b53 to 1276e3c Compare May 25, 2024 00:30
@thinkyhead thinkyhead force-pushed the bf2_url_check_PR branch 2 times, most recently from 25eb3a6 to a76d272 Compare June 16, 2024 21:58
@thinkyhead thinkyhead changed the title ✅ Automated URL checking 👷 Local URL checking script Jul 23, 2024
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Jul 23, 2024
@thinkyhead thinkyhead merged commit 4a5d8ba into MarlinFirmware:bugfix-2.1.x Jul 23, 2024
64 checks passed
@thinkyhead thinkyhead deleted the bf2_url_check_PR branch July 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: GitHub Admin GitHub actions, templates, website, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants