Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 More suppressible warnings #27009

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Apr 24, 2024

Description

  • Suppressible LCD contrast warning: Users don't need to know or care about something their LCD doesn't support, so let's make it easier to silence the warning. In fact, this entire warning could be removed, but I left it here anyway.
  • Suppressible Z_SAFE_HOMING warning: Homing with a probe to the right of a hotend usually doesn't require homing to the center of the bed if homing to X min (i.e.: Prusa MK2/3, Ender-3, etc.), so let's make it easier to silence the warning.
  • Suppressible user feedback warning: External G-code senders that communicate via serial can handle / remap G-codes as they are processed (like with BTT's TFT firmware), so it'd be nice to have the option to silence this warning on Marlin's side.

Benefits

Users won't have to venture into Warnings.cpp to override frequently encountered warnings and this is more in line with how we allow other warnings to be disabled without diving into core Marlin files.

@sjasonsmith sjasonsmith merged commit ca5a7be into MarlinFirmware:bugfix-2.1.x Apr 29, 2024
62 checks passed
@thisiskeithb thisiskeithb deleted the pr/suppressible_warnings branch April 29, 2024 01:26
RPGFabi pushed a commit to RPGFabi/Marlin that referenced this pull request Jun 15, 2024
* 🔧 Suppressible LCD contrast warning

* 🔧 Suppressible Z_SAFE_HOMING warning

* 🔧 Suppressible user feedback warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants