Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the comment by @sjasonsmith in #26845 (comment), i've taken a closer look at the timer rates set in the HC32 HAL and updated them according to the comment.
HCLK
, the rate of the main CPU core. The comment has been updated accordingly.CYCLES_PER_MICROSECOND
was removed to fallback to the default.HAL_TIMER_RATE
remains unchanged since it's used in the calculation forSTEPPER_TIMER_RATE
. The comment has been updated accordingly.Requirements
HC32-based printer
Benefits
Timing on HC32 should now function closer to what Marlin actually expects.
While i haven't observed a difference in e.g. print quality, this should still be a good thing.
Configurations
N/A
Related Issues
N/A