Process calibration movements as endstops #27204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Jun 24, 2024
|
Well that was an easy review…. |
Merged
tombrazier
pushed a commit
to tombrazier/Marlin
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original calibration object code worked by doing a series of small movements towards he calibration object and away again. This creates a lot of vibration which results in a noisy signal. It also means the calibration results are only as accurate as
MIN_STEPS_PER_SEGMENT.This PR replaces this behaviour to treat the calibration object as an endstop so the behaviour is now the same as homing.
Resulting in a speedier and more accurate
G425calibration.Requirements
Calibration object.
Benefits
Results in a speedier and more accurate
G425calibration.Configurations
Enable
CALIBRATION_GCODE