🔧 Simplify "sensitive pins" #27219
Merged
🔧 Simplify "sensitive pins" #27219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
added
C: Boards/Pins
T: Development
thinkyhead
force-pushed
the
bf2_sensitive_pins_cleanup_PR
branch
from
b1191b6 to
d1c80b0
Compare
thinkyhead
force-pushed
the
bf2_sensitive_pins_cleanup_PR
branch
from
d1c80b0 to
6960267
Compare
|
There are methods to remove duplicates from these pin lists at compile-time, but I'll need to play with coding assistants until I find a solution that works. I'll merge this now in case anyone else wants to take a crack at that interesting puzzle…. |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensitive pins array is only used in one place, so it can be simplified a lot by just inserting pins that are defined and not -1. This also eliminates a lot of junk in the preprocessor when this header is included.