fix settings.cpp check for ERR_EEPROM_NOPROM

[ellensp]

Description

Recent changes to settings.cpp in #27199 resulted in eeproms not being initialized, some ending up setting 0 for all settings

I believe this is the fix.

diff --git a/Marlin/src/module/settings.cpp b/Marlin/src/module/settings.cpp
index d4467b7687..a553d56745 100644
--- a/Marlin/src/module/settings.cpp
+++ b/Marlin/src/module/settings.cpp
@@ -1823,7 +1823,7 @@ void MarlinSettings::postprocess() {
     EEPROM_Error eeprom_error = ERR_EEPROM_NOERR;
 
     const EEPROM_Error check = check_version();
-    if (check == ERR_EEPROM_VERSION) return eeprom_error;
+    if (check == ERR_EEPROM_NOPROM) return eeprom_error;
 
     uint16_t stored_crc;

While dbuezas proposed a slight variant

diff --git a/Marlin/src/module/settings.cpp b/Marlin/src/module/settings.cpp
index d4467b7687..a553d56745 100644
--- a/Marlin/src/module/settings.cpp
+++ b/Marlin/src/module/settings.cpp
@@ -1823,7 +1823,7 @@ void MarlinSettings::postprocess() {
     EEPROM_Error eeprom_error = ERR_EEPROM_NOERR;
 
     const EEPROM_Error check = check_version();
-    if (check == ERR_EEPROM_VERSION) return eeprom_error;
+    if (check == ERR_EEPROM_NOPROM) return ERR_EEPROM_NOERR;
 
     uint16_t stored_crc;

This PR added my version for consideration

Requirements

EEPROM

Benefits

Works as expected

Related Issues

• [BUG] M501 logic with version mismatch #27236
• [BUG] Wrong MPC settings can cause thermal runaway #27253
• Load settings after showing bootscreen #27199 (comment)

[thisiskeithb]

resulted in eeproms not being initialized, some ending up setting 0 for all settings

...and causing thermal runaway:

• [BUG] Wrong MPC settings can cause thermal runaway #27253