Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HC32: update CRICITAL_SECTION macros #27283

Merged
merged 2 commits into from
Jul 18, 2024
Merged

HC32: update CRICITAL_SECTION macros #27283

merged 2 commits into from
Jul 18, 2024

Conversation

shadow578
Copy link
Contributor

Description

updates the CRITICAL_SECTION_START and CRITICAL_SECTION_END macros of the HC32 HAL to actually compile.
implementation is based on OpenHC32Boot.

Requirements

see related issue

Benefits

fix ProUI on HC32

Configurations

see related issue

Related Issues

#27282

@shadow578 shadow578 mentioned this pull request Jul 17, 2024
Closed
1 task
@thisiskeithb thisiskeithb linked an issue Jul 17, 2024 that may be closed by this pull request
[BUG] HC32 + ProUI __iCliRetVal / __iSeiRetVal not declared in this scope #27282
Closed
1 task
@thinkyhead thinkyhead added the T: HAL & APIs Topic related to the HAL and internal APIs. label Jul 17, 2024
@thinkyhead thinkyhead marked this pull request as ready for review July 17, 2024 23:17
@thinkyhead
Copy link
Member

thinkyhead commented Jul 17, 2024 •
edited
Loading

Would it be helpful to tie any of the platform / board / platform_packages to specific version tags or commit IDs? It looks like both the old code and the new code pass CI testing, so I presume this is a longstanding deprecation in the platform…?

@thinkyhead thinkyhead merged commit 29a5006 into MarlinFirmware:bugfix-2.1.x Jul 18, 2024
62 checks passed
@shadow578 shadow578 deleted the fix/hc32-critical-section branch July 18, 2024 06:24
@shadow578
Copy link
Contributor Author

shadow578 commented Jul 18, 2024 •
edited
Loading

so I presume this is a longstanding deprecation in the platform…?

aaik both functions __iCliRetVal and __iSeiRetVal never existed in the HC32 platform...
I believe that the CRITICAL_SECTION macros are just not used in most configurations relevant to HC32, so it wasn't noticed until now.

Would it be helpful to tie any of the platform / board / platform_packages to specific version tags or commit IDs?

i'll look into it and create a PR

EDIT PR created @ #27289

@shadow578 shadow578 mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HC32 + ProUI __iCliRetVal / __iSeiRetVal not declared in this scope
2 participants
@shadow578 @thinkyhead