set_axis_position()
potential unused
#27293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in module/stepper.cpp
Stepper::set_axis_position()
true intentions may be underutilized. it appears to be used only once in planner.cpp for onlyE_AXIS
So, I removed the call for other Axis' and renamed to
set_e_axis_position
to indicate its actual purpose.I suppose this may get rid of the functions "future proofing", however, it is beyond me if this function has another use based on the original purpose.
For now, this change suites it for now.
Requirements
Benefits
Remove unused code.
Better understanding of code.
Configurations
Related Issues