-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Fix missing _lcd_toggle_bed_leveling #27439
🩹 Fix missing _lcd_toggle_bed_leveling #27439
Conversation
thinkyhead
commented
Sep 24, 2024
- Fix missing _lcd_toggle_bed_leveling
- Update helper scripts for Darwin compatibility
f648588
to
0e09131
Compare
Dumb question - is this the same as #27421 ? |
Taking notes in the form of code, it looks like I forgot with the new probe+leveling menu that I need to include the callback to toggle leveling anytime bed leveling exists at all, so I removed all the old conditions. Should we remove the ability to toggle leveling only as part of |
0e09131
to
d9705d2
Compare
I'm not exactly sure. I haven't had the time to have my head in Marlin-space for a while. I guess the baptism by fire will be if the previously working build configurations still build and we have enough space for previously working configs in those space-limited environments. I'll check back in after a few days builds if there's any previously working builds that no longer work. |
It seems like a couple of previously working builds using the
Prior to this breakage, this build was working. I've also noticed that the STM32F401RC_creality platform also gets the same compile error:
|
that is why my pr removed the feature with SLIM_LCD_MENUS enabled, vs this pr which made the feature work.... |