add GCODE_CASE_INSENSITIVE support to e_parser #27449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed on Discord that with GCODE_CASE_INSENSITIVE enabled you could m0-m1 - Unconditional stop as expected, but m108 did not work.
The reason the emergency parser only looks for uppercase characters in the serial buffer.
Added support for lowercase to also work when GCODE_CASE_INSENSITIVE is enabled.
Requirements
GCODE_CASE_INSENSITIVE
EMERGENCY_PARSER
Benefits
EMERGENCY_PARSER works with GCODE_CASE_INSENSITIVE