remove hardcoded SHAPING_FREQ_X from SHAPING_MENU #27499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed in #27475 (comment)
That enabling SHAPING_MENU without INPUT_SHAPING_X (but with another axes enabled) causes a compile error
This is due to the hardcoded use of SHAPING_FREQ_X in the macro SHAPING_MENU_FOR_AXIS
This macro is used to generate the shaping menu items for X,Y and Z
When shaping for the axis is enabled the menu shows the settings for SHAPING_FREQ and SHAPING_ZETA
You can also disable each axis.
This issue is when you enable a disabled axis it needs a default SHAPING_FREQ, it is currently hardcoded to use SHAPING_FREQ_X
This breaks if you don't have INPUT_SHAPING_X enabled.
I updated the Macro SHAPING_MENU_FOR_AXIS to use the correct SHAPING_FREQ_{X|Y|Z} for each axis, so SHAPING_FREQ_X is only used if you have INPUT_SHAPING_X
Requirements
SHAPING_MENU
with any combination of
INPUT_SHAPING_X
INPUT_SHAPING_Y
INPUT_SHAPING_Z
Benefits
Builds as expected
Configurations
Configuration that triggers the issue.zip
Related Issues