Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout descr. in configuration_store.cpp #3005

Merged
merged 1 commit into from
Mar 6, 2016

Conversation

thinkyhead
Copy link
Member

  • Update the layout description with current version ID.
  • Move M666 Z to the correct place.
  • Wrap a non-gcode output line in if (!forReplay).

@thinkyhead thinkyhead force-pushed the rcbugfix_eeprom branch 8 times, most recently from 6162cf5 to cc6fd1f Compare February 18, 2016 03:43
@Blue-Marlin
Copy link
Contributor

How about a ';' in front of the comments. Then they should be readable by humans and ignored as comments by the g-code interpreter. Would save all the if (!forReplay) stuff.

@thinkyhead
Copy link
Member Author

@Blue-Marlin The headings would definitely benefit by getting a semicolon in front.

The forReplay flag may actually be more useful in the future. I've been proposing that the output from M503 might double as the data written to EEPROM. Then the function to restore settings from EEPROM need only run the GCode stored in EEPROM, with no more version numbers needed. So the forReplay flag was designed to produce the shortest possible output, in case it might need to be written to EEPROM.

That said, so far I haven't written the functions to write these strings to EEPROM, but it should be a pretty simple task. I'll look at it more closely when I get into wrapping up the EEPROM code into a class.

thinkyhead added a commit that referenced this pull request Mar 6, 2016
Fix layout descr. in configuration_store.cpp
@thinkyhead thinkyhead merged commit adc25db into MarlinFirmware:RCBugFix Mar 6, 2016
@thinkyhead thinkyhead deleted the rcbugfix_eeprom branch March 24, 2016 07:48
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants