Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress warnings #3149

Merged
merged 1 commit into from Mar 18, 2016
Merged

suppress warnings #3149

merged 1 commit into from Mar 18, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2016

No description provided.

@thinkyhead
Copy link
Member

What if we define the function this way, with const on the second argument (instead of casting to char * on the function call)? Does that also get rid of the warning?

void lcd_implementation_drawedit(const char* pstr, const char* value)

thinkyhead added a commit that referenced this pull request Mar 18, 2016
@thinkyhead thinkyhead merged commit 7d25c10 into MarlinFirmware:RCBugFix Mar 18, 2016
@ghost ghost deleted the patch-1 branch March 19, 2016 07:24
@ghost
Copy link
Author

ghost commented Mar 19, 2016

I apologize for the late reply,

void lcd_implementation_drawedit(const char* pstr, const char* value)

it's possible.
changes in codes are here.
https://github.com/esenapaj/Marlin/commit/dfe124ab220f31ccda5bb1e7b00d8e20a29fac04

@thinkyhead thinkyhead mentioned this pull request Mar 19, 2016
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Mar 19, 2016
@thinkyhead
Copy link
Member

With #3176 it encouraged the use of const in more places where it should be used anyway. It's a magic word, that const, though it has many mysterious meanings.

@ghost
Copy link
Author

ghost commented Mar 19, 2016

This page is I think it's helpful.
docs.oracle.com/cd/E19059-01/wrkshp50/805-4956/bajbebbg/index.html
http://docs.oracle.com/cd/E19059-01/wrkshp50/805-4956/bajbebbg/index.html

@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants