Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #3250

Merged
merged 1 commit into from Mar 26, 2016
Merged

Fix typo #3250

merged 1 commit into from Mar 26, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 25, 2016

These are salvaged from closed-PR #3216.

These are salvaged from closed-PR #3216.
@AnHardt
Copy link
Contributor

AnHardt commented Mar 26, 2016

@esenapaj
I'm very glad about you, correcting my spelling.
Even more glad i'd be, if you had commented the matter. Are these function call really too late/early`?

If you think yes - let's talk about that and do it the right way, instead of correcting the spelling.

@ghost
Copy link
Author

ghost commented Mar 26, 2016

Fixing "to late/early" to "too late/early" was transacted by @thinkyhead.
I can't be determined whether those are really too late/early or not,
because PR #3082(also #2820, #2819) are difficult for me.

@thinkyhead
Copy link
Member

A lot of general code cleanup has come through lately with these kinds of tweaks to comments, adding GPL headers, etc. I wouldn't take it to have any other implications. However, these comments were interesting, so it seemed better not to remove them, since comments like these (which appear here and there in the code) indicate that some code is under scrutiny or not fully trusted. The authors of such comments might settle upon an answer and remove them later, so I always try to leave them in.

@thinkyhead thinkyhead merged commit e4039a9 into MarlinFirmware:RCBugFix Mar 26, 2016
@ghost ghost deleted the patch-1 branch March 26, 2016 07:54
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants