Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups ahead of more… #4789

Merged
merged 26 commits into from
Sep 13, 2016
Merged

Various cleanups ahead of more… #4789

merged 26 commits into from
Sep 13, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Sep 12, 2016 •
edited
Loading

Various changes to facilitate upcoming changes to leveling, etc.

  • Conditionals for different forms of leveling
  • Additional macros for maths
  • Standardize SCARA config, clean up kinematics
  • Move setup() and loop() to the end of Marlin_main.cpp
  • Move delta homing and Z safe homing to separate functions
  • Allow M0/M1 to be used without a controller (continue with M108)
  • Generalize naming for kinematics, not just delta
  • Clean up and repair planner methods
  • Add Planner::unapply_leveling to remove leveling from a "logical" position
  • Use a counting method to sanity check controllers, machine types
  • Reduce the size of 3-point leveling code
  • Use reset_bed_level for both linear and non-linear leveling

@thinkyhead thinkyhead force-pushed the rc_better_leveling_etc branch 23 times, most recently from f798137 to a513da1 Compare September 13, 2016 08:14
@thinkyhead
Move delta homing to its own function
c84b14c
@thinkyhead
Move z safe homing to its own function
b403491
@thinkyhead
Add position_is_reachable, use in home_z_safely
786d1af
@thinkyhead
Implement M0/M1 for EMERGENCY_PARSER
c5fa708
@thinkyhead
Rename delta_grid spacing for general nonlinear
acd1b6e
@thinkyhead
sync_plan_position_delta => sync_plan_position_kinematic
d4f21af
@thinkyhead
Fix planner leveling and rename arguments
c109399 
Use lx, ly, lz for “logical” positions
@thinkyhead
Rename set_cartesian_from_steppers, cartesian_position
e529c64
@thinkyhead
Patch to fix kinematics
d65f5d8
@thinkyhead
Fix up untilted_stepper_position and set_current_from_steppers_for_axis
82be650
@thinkyhead
bed_level => bed_level_grid
a9ed232
@thinkyhead
Clean up sanity check for LCD_PROGRESS_BAR
3236762
@thinkyhead
Use count method for kinematic sanity check
40785ce
@thinkyhead
Sanity check for more than 1 controller
41d8149
@thinkyhead
Unify reset_bed_level for linear/non-linear
4f75ce6
@thinkyhead
Shrink 3-point leveling code
0e38bea
@thinkyhead
Clean up serial out code
788a16f
@thinkyhead
Various code style adjustments
61284cb
@thinkyhead
Reformat, rearrange, tweak, and document
b1a60e8 
- Add comments to several functions
- Add an option to use Fast SQRT for Delta IK
- Group related functions together
- Outdent some leveling-related functions
@thinkyhead
Apply fixed EXTRUDER_RUNOUT_PREVENT
9b0931e
@thinkyhead thinkyhead force-pushed the rc_better_leveling_etc branch 3 times, most recently from fee88f6 to 9b0931e Compare September 13, 2016 08:56
@thinkyhead thinkyhead mentioned this pull request Sep 13, 2016
Closed
@thinkyhead thinkyhead merged commit 94d5cf8 into MarlinFirmware:RCBugFix Sep 13, 2016
@thinkyhead thinkyhead deleted the rc_better_leveling_etc branch September 13, 2016 10:21
@thinkyhead thinkyhead mentioned this pull request Sep 17, 2016
Closed
@thinkyhead thinkyhead mentioned this pull request Oct 24, 2016
Closed
@ghost ghost mentioned this pull request Nov 6, 2016
Merged
@AnHardt AnHardt mentioned this pull request Jul 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
F: Calibration PR: General Cleanup PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkyhead